[FC-0036] feat: Update ObjectTagView - #180
Conversation
|
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@ChrisChV Is this ready for review? |
|
@bradenmacdonald Yes, It's ready 👍 |
|
@ChrisChV It LGTM. I'll let @yusuf-musleh test it first before I merge it though. Once we merge this and update edx-platform, won't it break tagging until we've updated course-authoring too though? It may have been better to implement this in a backwards compatible way. But I guess it's fine, as long as we coordinate the merges all at the same time. |
Yes, It is necessary to merge openedx/frontend-app-authoring#939 and openedx/openedx-platform#34490 at the same time |
yusuf-musleh
left a comment
There was a problem hiding this comment.
👍 @ChrisChV Works great and looks good to me too! Just a small nit/question.
- I tested this: Tested as part of openedx/frontend-app-authoring#939
- I read through the code
-
I checked for accessibility issues -
Includes documentation
|
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
@bradenmacdonald could you create a new tag with the version |
|
@ChrisChV Done! |
Description
Updates ObjectTagView Put request to update multiple taxonomies in one request
Supporting information
Testing instructions